On Tue, Jan 28, 2020 at 10:30 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Eric, > > On Tue, Jan 28, 2020 at 4:01 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > On Mon, Jan 27, 2020 at 04:22:53PM +0100, Geert Uytterhoeven wrote: > > > On Mon, Jan 27, 2020 at 4:08 PM Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote: > > > > Deal gracefully with the event of being handed a scatterlist > > > > which is shorter than expected. > > > > > > > > This mitigates a crash in some cases due to > > > > attempt to map empty (but not NULL) scatterlists with none > > > > zero lengths. > > > > > > > > Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> > > > > Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > > > > > Thank you, boots fine on Salvator-XS with R-Car H3ES2.0, and > > > CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=y. > > > > > > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > Note that you need to *unset* CONFIG_CRYPTO_MANAGER_DISABLE_TESTS to enable the > > self-tests. > > Sorry, that's what I meant (too used to type "=y" to enable something ;-) > > > So to run the full tests, the following is needed: > > > > # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set > > With just this, it no longer crashes. > > > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y > > With the extra tests enabled, it still crashes :-( > That's fine - this is the second issue I was talking about. The patch I sent before was not really a fix - more a stop gap designed to see if I understand the issue you are seeing. I will send out a patch fixing the root cause of both and this should resolve both issues. I just want to run it through some internal tests to make sure it did not break something else first. Thanks! Gilad
