Hi Neil,
On Wed, 11 Dec 2019 at 14:11, Anand Moon <linux.amoon@xxxxxxxxx> wrote:
>
> This patch adds the crypto hardware node for all GXBB SoCs.
>
> Cc: Corentin Labbe <clabbe@xxxxxxxxxxxx>
> Cc: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
> ---
> Tested on Odroid C2 GXBB
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 0cb40326b0d3..bac8fbfd4f01 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -14,6 +14,16 @@ / {
> compatible = "amlogic,meson-gxbb";
>
> soc {
> + crypto: crypto@c883e000 {
My mistake I got this reg value wrong, as per the
"S905_Public_Datasheet_V1.1.4" [0]
it should be *0xda832000 + offset*4*
I changes this at my end but I get kernel panic on loading the module.
# sudo modprobe tcrypt sec=1 mode=500
It's looks like the crypto node is wrongly configured.
> + compatible = "amlogic,gxbb-crypto";
> + reg = <0x0 0xc883e000 0x0 0x36>;
> + interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 189 IRQ_TYPE_EDGE_RISING>;
> + clocks = <&clkc CLKID_BLKMV>;
> + clock-names = "blkmv";
> + status = "okay";
> + };
> +
> usb0_phy: phy@c0000000 {
> compatible = "amlogic,meson-gxbb-usb2-phy";
> #phy-cells = <0>;
> --
> 2.24.0
>
[0] https://dn.odroid.com/S905/DataSheet/S905_Public_Datasheet_V1.1.4.pdf
-Anand
