Re: [PATCH 1/2] crypto: hisilicon - select NEED_SG_DMA_LENGTH in qm Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019/10/24 21:56, Herbert Xu wrote:
> On Thu, Oct 24, 2019 at 03:22:50PM +0200, Ard Biesheuvel wrote:
>>
>> If you are fixing a COMPILE_TEST failure, just add NEED_SG_DMA_LENGTH
>> as a dependency, or drop the COMPILE_TEST altogether (why was that
>> added in the first place?)
> 
> Because we want to maximise compiler coverage so that build failures
> can be caught at the earliest opportunity.
> 
> But a better fix would be to use
> 
> 	sg_dma_len(sg)

OK, will do by this. Thanks!

Best,
Zhou

> 
> instead of
> 
> 	sg->dma_length
> 
> Cheers,
> 




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux