On 2019/10/17 0:44, Florian Fainelli wrote:
> On 10/16/19 3:46 AM, YueHaibing wrote:
>> devm_platform_ioremap_resource() internally have platform_get_resource()
>> and devm_ioremap_resource() in it. So instead of calling them separately
>> use devm_platform_ioremap_resource() directly.
>
> Did your coccinelle script not cover
> drivers/char/hw_random/iproc-rng200.c somehow? Do you mind including it
> as a separate patch?
A patch from Markus Elfring has be queued:
commit a68b931932c5574aa5bd459529c766ba577c72b3
Author: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed Sep 18 09:09:22 2019 +0200
hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe()
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx>
Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Thanks
>
>>
>> YueHaibing (13):
>> hwrng: atmel - use devm_platform_ioremap_resource() to simplify code
>> hwrng: bcm2835 - use devm_platform_ioremap_resource() to simplify code
>> hwrng: exynos - use devm_platform_ioremap_resource() to simplify code
>> hwrng: hisi - use devm_platform_ioremap_resource() to simplify code
>> hwrng: ks-sa - use devm_platform_ioremap_resource() to simplify code
>> hwrng: meson - use devm_platform_ioremap_resource() to simplify code
>> hwrng: npcm - use devm_platform_ioremap_resource() to simplify code
>> hwrng: omap - use devm_platform_ioremap_resource() to simplify code
>> hwrng: pasemi - use devm_platform_ioremap_resource() to simplify code
>> hwrng: pic32 - use devm_platform_ioremap_resource() to simplify code
>> hwrng: st - use devm_platform_ioremap_resource() to simplify code
>> hwrng: tx4939 - use devm_platform_ioremap_resource() to simplify code
>> hwrng: xgene - use devm_platform_ioremap_resource() to simplify code
>>
>> drivers/char/hw_random/atmel-rng.c | 4 +---
>> drivers/char/hw_random/bcm2835-rng.c | 5 +----
>> drivers/char/hw_random/exynos-trng.c | 4 +---
>> drivers/char/hw_random/hisi-rng.c | 4 +---
>> drivers/char/hw_random/ks-sa-rng.c | 4 +---
>> drivers/char/hw_random/meson-rng.c | 4 +---
>> drivers/char/hw_random/npcm-rng.c | 4 +---
>> drivers/char/hw_random/omap-rng.c | 4 +---
>> drivers/char/hw_random/pasemi-rng.c | 4 +---
>> drivers/char/hw_random/pic32-rng.c | 4 +---
>> drivers/char/hw_random/st-rng.c | 4 +---
>> drivers/char/hw_random/tx4939-rng.c | 4 +---
>> drivers/char/hw_random/xgene-rng.c | 4 +---
>> 13 files changed, 13 insertions(+), 40 deletions(-)
>>
>
>
