On Mon, Oct 07, 2019 at 06:45:52PM +0200, Ard Biesheuvel wrote:
> Now that all users of generic ChaCha code have moved to the core library,
> there is no longer a need for the generic ChaCha skcpiher driver to
> export parts of it implementation for reuse by other drivers. So drop
> the exports, and make the symbols static.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> ---
> crypto/chacha_generic.c | 28 +++++++++-----------
> include/crypto/internal/chacha.h | 10 -------
> 2 files changed, 12 insertions(+), 26 deletions(-)
>
> diff --git a/crypto/chacha_generic.c b/crypto/chacha_generic.c
> index ebae6d9d9b32..a794df0e5b70 100644
> --- a/crypto/chacha_generic.c
> +++ b/crypto/chacha_generic.c
> @@ -12,6 +12,12 @@
> #include <crypto/internal/skcipher.h>
> #include <linux/module.h>
>
> +static void crypto_chacha_init(u32 *state, const struct chacha_ctx *ctx,
> + const u8 *iv)
> +{
> + chacha_init_generic(state, ctx->key, iv);
> +}
The 2 places that call this could just call chacha_init_generic() directly
instead.
- Eric
