Re: [PATCH v3 21/29] crypto: BLAKE2s - generic C library implementation and selftest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 07, 2019 at 06:46:02PM +0200, Ard Biesheuvel wrote:
> From: "Jason A. Donenfeld" <Jason@xxxxxxxxx>
> 
> The C implementation was originally based on Samuel Neves' public
> domain reference implementation but has since been heavily modified
> for the kernel. We're able to do compile-time optimizations by moving
> some scaffolding around the final function into the header file.
> 
> Information: https://blake2.net/
> 
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> Signed-off-by: Samuel Neves <sneves@xxxxxxxxx>
> Co-developed-by: Samuel Neves <sneves@xxxxxxxxx>
> [ardb: move from lib/zinc to lib/crypto and remove simd handling]
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>

FYI, I had left a few review comments on Jason's last version of this patch
(https://lkml.kernel.org/linux-crypto/20190326173759.GA607@zzz.localdomain/),
some of which Jason addressed in the Wireguard repository
(https://git.zx2c4.com/WireGuard) but they didn't make it into this patch.
I'd suggest taking a look at the version there.

- Eric



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux