On Wed, Jul 31, 2019 at 02:23:27PM +0000, Pascal Van Leeuwen wrote: > > From: Antoine Tenart <antoine.tenart@xxxxxxxxxxx> > > > What happens if i < 2 ? > > > Ok, I did not consider that as it can't happen for any kind of legal FW. But it > wouldn't be pretty (neither would 2 itself, BTW). I could throw an error for it > but it wouldn't make that much sense as we don't do any checks on the firm- > ware *contents* either ... So either way, if your firmware file is no good, you > have a problem ... The thing is to avoid doing harm to the kernel if a single driver can't work as expected, especially when we have an user input (the firmware). The firmware being a valid one is another topic. But honestly I'm not sure if a wrong returned value would change anything here, apart from not probing the driver successfully as we know something went wrong. Thanks, Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
