On Wed, Jul 31, 2019 at 11:37:08AM +0000, Pascal Van Leeuwen wrote: > > > In general we want to maximise compiler coverage under all config > > options so if we can make it compiler without too much effort that > > would be the preferred solution. > > > I understand that, and I tried to do that initially, but that wouldn't > work so I ended up with this as a compromise ... If it's too hard then #if is the way to go. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt