On Wed, Jun 12, 2019 at 01:35:36PM +0200, Sascha Hauer wrote: > On Wed, Jun 12, 2019 at 10:33:56AM +0000, Horia Geanta wrote: > > On 6/12/2019 12:40 PM, Sascha Hauer wrote: > > > Hi Horia, > > > > > > On Wed, May 15, 2019 at 01:35:16PM +0000, Horia Geanta wrote: > > >> For talitos, the problem is the lack of IV update. > > >> > > >> For caam, the problem is incorrect IV update (output IV is equal to last > > >> ciphertext block, which is correect for cbc, but not for ctr mode). > > >> > > >> I am working at a fix, but it takes longer since I would like to program the > > >> accelerator to the save the IV (and not do counter increment in SW, which > > >> created problems for many other implementations). > > > > > > Any news here? With the fix Ard provided gcm(aes) now works again, but > > > only as long as the crypto self tests are disabled. > > > > > I've recently submitted support for IV update done in HW (caam engine), > > which fixes this issue: > > https://patchwork.kernel.org/cover/10984927/ > > Thanks, I haven't seen this. I'll give it a try. This works here, thanks I don't have the original patch mails, so I'm adding it here: Tested-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |