On Mon, 17 Jun 2019 at 11:20, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, Jun 17, 2019 at 11:15:01AM +0200, Ard Biesheuvel wrote: > > > > Ah yes, thanks for reminding me. There was some debate in the past > > about this, but I don't remember the details. > > I think there were some controversy regarding whether the resulting > code lived in drivers/md or crypto. I think as long as drivers/md > is the only user of the said code then having it in drivers/md should > be fine. > > However, if we end up using/reusing the same code for others such as > fs/crypto then it might make more sense to have them in crypto. > Agreed. We could more easily test it in isolation and ensure parity between different implementations, especially now that we have Eric's improved testing framework that tests against generic implementations.