Re: [PATCH 2/2] crypto: algapi - reject NULL crypto_spawn::inst

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 06, 2019 at 12:46:06PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> It took me a while to notice the bug where the adiantum template left
> crypto_spawn::inst == NULL, because this only caused problems in certain
> cases where algorithms are dynamically loaded/unloaded.
> 
> More improvements are needed, but for now make crypto_init_spawn()
> reject this case and WARN(), so this type of bug will be noticed
> immediately in the future.
> 
> Note: I checked all callers and the adiantum template was the only place
> that had this wrong.  So this WARN shouldn't trigger anymore.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
>  crypto/algapi.c | 3 +++
>  1 file changed, 3 insertions(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux