On Sun, Jan 06, 2019 at 12:46:05PM -0800, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > crypto_grab_*() doesn't set crypto_spawn::inst, so templates must set it > beforehand. Otherwise it will be left NULL, which causes a crash in > certain cases where algorithms are dynamically loaded/unloaded. E.g. > with CONFIG_CRYPTO_CHACHA20_X86_64=m, the following caused a crash: > > insmod chacha-x86_64.ko > python -c 'import socket; socket.socket(socket.AF_ALG, 5, 0).bind(("skcipher", "adiantum(xchacha12,aes)"))' > rmmod chacha-x86_64.ko > python -c 'import socket; socket.socket(socket.AF_ALG, 5, 0).bind(("skcipher", "adiantum(xchacha12,aes)"))' > > Fixes: 059c2a4d8e16 ("crypto: adiantum - add Adiantum support") > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> > --- > crypto/adiantum.c | 4 ++++ > 1 file changed, 4 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt