On Fri, Jan 04, 2019 at 09:57:13AM +0000, David Howells wrote: > Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > > - u8 *iv = walk->iv; > > + u8 * const iv = walk->iv; > > Does adding this const actually gain anything? (this is done twice) > > David It makes it clearer what's going on, especially since some modes update the 'iv' pointer after each block (delaying the copy to 'walk.iv' until the end) but others can't do that. The 'const' is helpful to further distinguish these two cases, which were confused in both the pcbc and cfb implementations. - Eric
