Re: [PATCH 04/16] crypto: pcbc - remove bogus memcpy()s with src == dest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 04/16] crypto: pcbc - remove bogus memcpy()s with src == dest
From: David Howells <dhowells@xxxxxxxxxx>
Date: Fri, 04 Jan 2019 09:57:13 +0000
Cc: dhowells@xxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <20190104041625.3259-5-ebiggers@kernel.org>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <20190104041625.3259-5-ebiggers@kernel.org> <20190104041625.3259-1-ebiggers@kernel.org>

Eric Biggers <ebiggers@xxxxxxxxxx> wrote:

> -	u8 *iv = walk->iv;
> +	u8 * const iv = walk->iv;

Does adding this const actually gain anything?  (this is done twice)

David

Follow-Ups:
- Re: [PATCH 04/16] crypto: pcbc - remove bogus memcpy()s with src == dest
  - From: David Howells
- Re: [PATCH 04/16] crypto: pcbc - remove bogus memcpy()s with src == dest
  - From: Eric Biggers

References:
- [PATCH 04/16] crypto: pcbc - remove bogus memcpy()s with src == dest
  - From: Eric Biggers
- [PATCH 00/16] crypto: skcipher template simplifications and conversions
  - From: Eric Biggers

Prev by Date: Re: IPSec ESN: Packets decryption fail with ESN enabled connection
Next by Date: Re: [RFC PATCH] akcipher: Introduce verify2 for public key algorithms
Previous by thread: [PATCH 16/16] crypto: algapi - remove crypto_alloc_instance()
Next by thread: Re: [PATCH 04/16] crypto: pcbc - remove bogus memcpy()s with src == dest
Index(es):
- Date
- Thread

[Index of Archives] [Kernel] [Gnu Classpath] [Gnu Crypto] [DM Crypt] [Netfilter] [Bugtraq]

Powered by Linux