Hi Herbert, On Tue, Oct 2, 2018 at 5:18 AM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > size old new > > ---- ---- ---- > > 0 62 52 > > What is the old column? Is it the existing x86-64 implementation > in the kernel or something else? This needs to be made clear in the > patch description. Good idea. I'll make that more clear. > The same comment from the previous patch also stands here. Please > ensure that we only have one copy of chacha x86-64 code in the kernel. > Either replace the existing one right here or in a follow-up patch > in the same series. Yes indeed this happens within this same series. Jason