Hi Herbert, On Tue, Oct 2, 2018 at 5:15 AM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > I don't have any problems with this interface. > > However, I'm very unhappy about the fact that this adds another > copy of the chacha20 implementation to the kernel. Either this > is better than the one that we already have or it isn't. > > So if it's better please replace the existing chacha20 C > implementation with this or otherwise just adapt the existing > implementation to this interface. > > If we're replacing the existing one then you can either replace > it directly within this patch or in a subsequent patch but please > do it in the same series because otherwise we could wind up with > two implementations for years to come. Indeed this series takes care of removing the other implementation later on. In case it helps to see things visualized, here's the layout of the whole series: https://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux.git/log/?h=jd/wireguard Note that comments on this are probably a bit more useful than on the version posted to the mailing list, since I've already started incorporating quite a bit of feedback from v6, and so v7 will be posted sometime later containing these. Jason
