Hi Gilad, On Tue, Jul 24, 2018 at 9:32 AM Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote: > On Mon, Jul 23, 2018 at 5:35 PM, Geert Uytterhoeven > <geert@xxxxxxxxxxxxxx> wrote: > > On Mon, Jul 23, 2018 at 4:25 PM Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote: > >> On Mon, Jul 23, 2018 at 1:31 PM, Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote: > >> > On Mon, Jul 23, 2018 at 12:55 PM, Geert Uytterhoeven > >> > <geert@xxxxxxxxxxxxxx> wrote: > >> >> CC linux-crypto for the crash log. > >> >> > >> >> On Sun, Jul 22, 2018 at 7:28 AM Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote: > >> >>> On Thu, Jul 19, 2018 at 3:43 PM, Geert Uytterhoeven > >> >>> <geert@xxxxxxxxxxxxxx> wrote: > >> >>> > I've noticed CCREE is used with a LUKS-formatted disk, so I did some small > >> > ... > >> >> > >> >> $ cryptsetup benchmark > >> >> # Tests are approximate using memory only (no storage IO). > >> >> PBKDF2-sha1 478364 iterations per second for 256-bit key > >> >> PBKDF2-sha256 927943 iterations per second for 256-bit key > >> >> PBKDF2-sha512 360583 iterations per second for 256-bit key > >> >> PBKDF2-ripemd160 266677 iterations per second for 256-bit key > >> >> PBKDF2-whirlpool 115787 iterations per second for 256-bit key > >> >> # Algorithm | Key | Encryption | Decryption > >> >> aes-cbc 128b 46.0 MiB/s 46.7 MiB/s > >> >> serpent-cbc 128b N/A N/A > >> >> twofish-cbc 128b N/A N/A > >> >> aes-cbc 256b 46.5 MiB/s 46.4 MiB/s > >> >> serpent-cbc 256b N/A N/A > >> >> twofish-cbc 256b N/A N/A > >> >> Segmentation fault > >> >> > >> >> Oops. > >> >> > >> >> ccree e6601000.crypto: Unsupported data size 65536. > >> >> Unable to handle kernel paging request at virtual address ffffffbf5c3c3c20 > >> > > >> > Oy. Thank you for reporting this. I'll take a look at what is going on ASAP. > >> > >> hmm... well, the plot thickens. > >> > >> I was able to recreate the "Unsupported data size 65536" message and > >> now trying to understand > >> why the check that causes it is there but - I wasn't able to get a > >> crash, nor do I understand why > >> this condition would result in a crash (it ends up returning -EINVAL)... :-( > >> > >> I am surely using a different tree though - I'm based on the > >> cryptodev/master tree with cherry picking of just R-Car ccree clocks > >> and enabling. > >> > >> I was thinking maybe it's a fix that is already in upstream cryptodev > >> tree but not in your tree but didn't manage to identify any obvious > >> suspects > >> > >> What tree are you based off? > > > > My tree is based on renesas-drivers-2018-07-17-v4.18-rc5 from > > https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/ > > > > Do you want me to try something different? > > I've tried booting your tree and see the same behavior - "Unsupported > data size" error message but no crash. > > I'm running on an Savator-X R-Car H3 ES1.0 board. > > Not really sure how to proceed. > > Maybe you can send me your exact .config file? I cannot reproduce the crash using renesas_defconfig + CONFIG_CRYPTO_DEV_CCREE=y + CONFIG_CRYPTO_USER_API_SKCIPHER=y. I can reproduce it on Salvator-X with R-Car H3 ES1.0 and Salvator-XS with R-Car H3 ES2.0 using the attached config. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Attachment:
config-salvator-x.gz
Description: application/gzip
