Re: [PATCH v2 0/2] hwrng: Add support for qcpm v2 hwrng

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/21/18 11:27 PM, Vinod wrote:
I have checked the series.

I am not sure I follow that this is v2 and you read CONFIG register.
Apart from that other changes look mostly okay with few nitpicks:)

It seems that there are two registers sets for v2 hardware, one with CONFIG and one without. I just chose to support the one with.

But there is a bigger concern raised by Herbert on this not being a true
RNG and thus should be moved to crypto/

I've asked some of the crypto experts in Q to answer that question.

I have the changes ready for that, I will test them later today and
share with you, ACPI addition should be easy on that driver

Ok. Feel free to just merge my ACPI changes into yours. Technically, it's only a couple lines that are really ACPI-specific.

I will probably need you to test my patches as my last day at Qualcomm
is the 26th.
Sad to hear that and good luck in your new adventure

Thanks.

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux