On 21-06-18, 10:17, Timur Tabi wrote: > On Tue, Jun 19, 2018 at 4:54 AM, Vinod Koul <vinod.koul@xxxxxxxxxx> wrote: > > This series adds support for newer version of hwrng as found in > > Qualcomm SoCs. To do that add new v2 compatible string and driver_data > > values for v2. > > It's amazing you're sending this now, because I also have a PRNG > patchset that I'm sending out today that adds support for v2 chips on > an ACPI platform. > > I'll send my patches as-is, and we'll just have to work to resolve the > merge conflicts. I have checked the series. I am not sure I follow that this is v2 and you read CONFIG register. Apart from that other changes look mostly okay with few nitpicks :) But there is a bigger concern raised by Herbert on this not being a true RNG and thus should be moved to crypto/ I have the changes ready for that, I will test them later today and share with you, ACPI addition should be easy on that driver > I will probably need you to test my patches as my last day at Qualcomm > is the 26th. Sad to hear that and good luck in your new adventure -- ~Vinod
