[bug report] crypto: chtls - Inline TLS record Rx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Atul Gupta,

The patch b647993fca14: "crypto: chtls - Inline TLS record Rx" from
Mar 31, 2018, leads to the following static checker warning:

	drivers/crypto/chelsio/chtls/chtls_io.c:1412 chtls_pt_recvmsg()
	warn: inconsistent indenting

drivers/crypto/chelsio/chtls/chtls_io.c
  1401                  if (sk->sk_backlog.tail) {
  1402                          release_sock(sk);
  1403                          lock_sock(sk);
  1404                          chtls_cleanup_rbuf(sk, copied);
  1405                          continue;
  1406                  }
  1407  
  1408                  if (copied >= target)
  1409                          break;
  1410                  chtls_cleanup_rbuf(sk, copied);
  1411                  sk_wait_data(sk, &timeo, NULL);
  1412                          continue;

The continue is indented too far.  Were you intending to check the
return from sk_wait_data() or something?

  1413  found_ok_skb:
  1414                  if (!skb->len) {
  1415                          skb_dst_set(skb, NULL);
  1416                          __skb_unlink(skb, &sk->sk_receive_queue);
  1417                          kfree_skb(skb);
  1418  
  1419                          if (!copied && !timeo) {
  1420                                  copied = -EAGAIN;
  1421                                  break;
  1422                          }
  1423  
  1424                          if (copied < target) {
  1425                                  release_sock(sk);
  1426                                  lock_sock(sk);
  1427                                  continue;
  1428                          }
  1429                          break;
  1430                  }


regards,
dan carpenter



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux