[bug report] crypto: chtls - Inline TLS record Tx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Atul Gupta,

The patch 36bedb3f2e5b: "crypto: chtls - Inline TLS record Tx" from
Mar 31, 2018, leads to the following static checker warning:

	drivers/crypto/chelsio/chtls/chtls_io.c:1210 chtls_sendpage()
	info: ignoring unreachable code.

drivers/crypto/chelsio/chtls/chtls_io.c
  1188                  skb->len += copy;
  1189                  if (skb->len == mss)
  1190                          tx_skb_finalize(skb);
  1191                  skb->data_len += copy;
  1192                  skb->truesize += copy;
  1193                  sk->sk_wmem_queued += copy;
  1194                  tp->write_seq += copy;
  1195                  copied += copy;
  1196                  offset += copy;
  1197                  size -= copy;
  1198  
  1199                  if (corked(tp, flags) &&
  1200                      (sk_stream_wspace(sk) < sk_stream_min_wspace(sk)))
  1201                          ULP_SKB_CB(skb)->flags |= ULPCB_FLAG_NO_APPEND;
  1202  
  1203                  if (!size)
  1204                          break;
  1205  
  1206                  if (unlikely(ULP_SKB_CB(skb)->flags & ULPCB_FLAG_NO_APPEND))
  1207                          push_frames_if_head(sk);
  1208                  continue;
                        ^^^^^^^^
  1209  
  1210                  set_bit(SOCK_NOSPACE, &sk->sk_socket->flags);
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Not reachable.

  1211          }
  1212  out:
  1213          csk_reset_flag(csk, CSK_TX_MORE_DATA);
  1214          if (copied)
  1215                  chtls_tcp_push(sk, flags);
  1216  done:
  1217          release_sock(sk);
  1218          return copied;
  1219  
  1220  do_error:
  1221          if (copied)
  1222                  goto out;
  1223  
  1224  out_err:
  1225          if (csk_conn_inline(csk))

regards,
dan carpenter



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux