On Fri, Dec 22, 2017 at 08:41:10AM +0100, Stephan Mueller wrote: > > Shouldn't we then rather use a white list instead of a black list? > > > > Most other problems however would be bugs in the template code. > > The first thing a template does when it creates an instance is > > to check whether the resulting algorithm would fulfil the requested > > type/mask using crypto_check_attr_type. So if that's not working > > then we should fix it there as it may also be triggered via other > > code paths that can create instances. > > I think I understand that, but does user space need to utilize this logic? I'm open to a white list as well. But we should certainly fix the underlying bugs rather than just papering over them as they could come back via other channels. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
