On Fri, Dec 22, 2017 at 08:50:01AM +0100, Stephan Mueller wrote:
> Am Freitag, 22. Dezember 2017, 08:48:03 CET schrieb Herbert Xu:
>
> Hi Herbert,
>
> > On Tue, Dec 19, 2017 at 10:31:22AM +0000, Jonathan Cameron wrote:
> > > This variable was increased and decreased without any protection.
> > > Result was an occasional misscount and negative wrap around resulting
> > > in false resource allocation failures.
> > >
> > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > > Fixes: 2d97591ef43d ("crypto: af_alg - consolidation of duplicate code")
> >
> > Actually I think it used to be fine because we held the socket
> > lock in the async callback. It only got broken when we removed
> > the socket lock from the callback.
>
> But we cannot hold the lock in the async callback since it may be called in
> interrupt context.
I know. I'm just saying that the bug was introduced in the commit
that removed the socket lock rather than the commit that introduced
this originally.
Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
