On Thu, Dec 14, 2017 at 4:30 PM, Philippe Ombredanne <pombredanne@xxxxxxxx> wrote: > Gilad, > > On Thu, Dec 14, 2017 at 3:02 PM, Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote: >> The ccree driver has had a none standard sysfs interface for debugging. >> Replace it with a proper debugfs interface. >> >> Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> > > <snip> > >> --- /dev/null >> +++ b/drivers/staging/ccree/cc_debugfs.c >> @@ -0,0 +1,114 @@ >> +/* >> + * Copyright (C) 2012-2017 ARM Limited or its affiliates. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, see <http://www.gnu.org/licenses/>. >> + */ > > Could you use the new SPDX tags instead of this fine and long > boilerplate? See Thomas doc for details [1] That's a good idea. I'll prepare a patch set to turn the entire driver. Thanks, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru