Gilad, On Thu, Dec 14, 2017 at 3:02 PM, Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote: > The ccree driver has had a none standard sysfs interface for debugging. > Replace it with a proper debugfs interface. > > Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> <snip> > --- /dev/null > +++ b/drivers/staging/ccree/cc_debugfs.c > @@ -0,0 +1,114 @@ > +/* > + * Copyright (C) 2012-2017 ARM Limited or its affiliates. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, see <http://www.gnu.org/licenses/>. > + */ Could you use the new SPDX tags instead of this fine and long boilerplate? See Thomas doc for details [1] You could spare the world from ~14 lines of this fine legalese with this: // SPDX-License-Identifier: GPL-2.0 // Copyright (C) 2012-2017 ARM Limited or its affiliates. If you wonder about the C++ style comment, read Thomas doc patches [1] and check the comments made on the list by Linus. If you could spread the word out in your team too, this would be much welcomed! Thanks! [1] https://lkml.org/lkml/2017/12/4/934 -- Cordially Philippe Ombredanne
