On Thu, Mar 09, 2017 at 11:02:41AM +0100, Stephan Müller wrote: > > > > The patch 0001-crypto-algif_aead-copy-AAD-from-src-to-dst_separate.patch > > > simply copies the AAD over from TX SGL to RX SGL. The pro is that the > > > patch is small. The con is that this approach does *not* provide an > > > in-place crypto operation. > > > > I prefer this patch with the proviso that it copy the whole thing > > instead of just the AD. That way you can just feed the dst memory > > to crypto_aead for in-place operation. Of course you have to mangle > > the tag data onto the dst SG list for decryption but it shouldn't > > be too hard. > > I thought that is exactly the second patch. It copies the entire data to the > dst SGL and extends the SGL with the tag in case of decryption. Are you sure? The patch says: + /* copy AAD from src to dst */ + err = crypto_aead_copy_sgl(ctx->null, areq->tsgl, + areq->first_rsgl.sgl.sg, ctx->aead_assoclen); Which seems to only copy the AD. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
