On Wed, Dec 28, 2016 at 05:18:01PM +0800, Herbert Xu wrote: > On Tue, Dec 27, 2016 at 06:04:52PM +0800, Herbert Xu wrote: > > On Fri, Dec 09, 2016 at 02:33:51PM +0000, Ard Biesheuvel wrote: > > > This converts the ChaCha20 code from a blkcipher to a skcipher, which > > > is now the preferred way to implement symmetric block and stream ciphers. > > > > > > This ports the generic and x86 versions at the same time because the > > > latter reuses routines of the former. > > > > > > Note that the skcipher_walk() API guarantees that all presented blocks > > > except the final one are a multiple of the chunk size, so we can simplify > > > the encrypt() routine somewhat. > > > > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > > > > Patch applied. Thanks. > > I'm reverting this patch because it breaks the build on ARM without > the two subsequent patches. > > When resubmitting please make sure that the kernel can build and > work after each patch. Otherwise git bisections will fail. Sorry, it only broke the build because I applied your other two patches first. So I'll just revert all three and it should work. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html