> On 28 Dec 2016, at 09:10, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > >> On Tue, Dec 27, 2016 at 06:35:46PM +0000, Ard Biesheuvel wrote: >> >> OK, I will try to hack something up. >> >> One thing to keep in mind though is that stacked chaining modes should >> present the data with the same granularity for optimal performance. >> E.g., xts(ecb(aes)) should pass 8 blocks at a time. How should this >> requirement be incorporated according to you? > > xts tries to do a page at a time, which should be good enough, no? > Yes, if the xts chaining mode driver invokes the ecb transform with that granularity, it should be fine. Note that this is a theoretical concern for this mode in particular, given that the bit sliced aes code implements the xts bits as well > In general this parameter should be visible to internal API users > such as xts so they could use it to determine how it wants to > structure its walks. > Ok, so that implies a field in the skcipher algo struct then, rather than some definition internal to the driver? > Cheers, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
