Re: [PATCH] crypto: marvell - Don't copy hash operation twice into the SRAM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Le 02/12/2016 à 09:58, Romain Perier a écrit :
Hi,

Le 01/12/2016 à 17:27, Gregory CLEMENT a écrit :
Hi Romain,

 On jeu., déc. 01 2016, Romain Perier
<romain.perier@xxxxxxxxxxxxxxxxxx> wrote:

No need to copy the template of an hash operation twice into the SRAM
from the step function.


Does this patch fix a bug ot it is jsute a cleanup/improvement?

If it is a bug you should CC stable and add use the Fixes tag.

Gregory


No, it just removes a initialization that is done twice. I have checked,
it cannot overwrite the context of the operation that was previously
copied (by the for loop), so it does not fix anything.



Well, I have a second fix that depends on this one. The second fix
will be marked as "Fixes" (to be backported to stable) so it would introduce a ordering issue. I think that I will resend a patch series with these two patches and tag both as "Fixes". Please ignore this patch for now.


Regards,
Romain
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux