Am Mittwoch, 16. November 2016, 16:57:42 CET schrieb Herbert Xu: Hi Herbert, > On Tue, Nov 15, 2016 at 08:06:47PM +0100, Stephan Mueller wrote: > > Shall the fix be rolled into the patch together with the fix for the tag > > value as well as the crash fix? Or can we have a stand-alone patch fixing > > this. > I think these are two separate issues and we don't need to fix them > all in one go. I will resubmit the patches regarding the tag and the bug fix then. > > > Btw., how do you suggest that should be fixed? I would assume that this > > needs to be fixed on a per-implementation basis. I tested authenc and it > > copies the buffers over. gcm_base(ctr-aes-aesni,ghash-clmulni), > > rfc4106-gcm-aesni or ccm_base(ctr-aes-aesni,aes-aesni) do not copy the AD > > over. > > We should fix as much as we can and then add a testmgr test to find > the rest. One thing occurred to me: The copying of the AD would only be done of src != dst. For the AF_ALG interface, I thing we always have src != dst due to the user space/kernel space translation. That means the kernel copies the AD around even in user space src == dst. Isn't that a waste? I.e. shouldn't we handle the AD copying rather in user space than in kernel space? Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
