Re: [PATCH 2/3] crypto: AF_ALG - disregard AAD buffer space for output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Samstag, 12. November 2016, 10:13:02 CET schrieb Herbert Xu:

Hi Herbert,

> On Sat, Nov 12, 2016 at 03:03:36AM +0100, Stephan Mueller wrote:
> > When you have separate buffers, the kernel does not seem to copy the AD
> > over to the target buffer.
> 
> OK we should definitely fix that.

Shall the fix be rolled into the patch together with the fix for the tag value 
as well as the crash fix? Or can we have a stand-alone patch fixing this.

Btw., how do you suggest that should be fixed? I would assume that this needs 
to be fixed on a per-implementation basis. I tested authenc and it copies the 
buffers over. gcm_base(ctr-aes-aesni,ghash-clmulni), rfc4106-gcm-aesni or 
ccm_base(ctr-aes-aesni,aes-aesni) do not copy the AD over.

Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux