On 11/27/2015, 02:06 PM, Herbert Xu wrote: > On Thu, Nov 26, 2015 at 08:56:29PM +0100, Jiri Slaby wrote: >> >> diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c >> index a064237ff362..f003df162e09 100644 >> --- a/drivers/char/hw_random/core.c >> +++ b/drivers/char/hw_random/core.c >> @@ -238,7 +238,10 @@ static ssize_t rng_dev_read(struct file *filp, char __user *buf, >> goto out; >> } >> >> - mutex_lock(&reading_mutex); >> + if (mutex_lock_interruptible(&reading_mutex)) { >> + err = -EINTR; > > Shouldn't this be ERESTARTSYS? Yes, it actually can, given the retval is returned only if no data were read yet. thanks, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html