On Sun, Oct 11, 2015 at 02:55:05PM +0800, Herbert Xu wrote: > On Sat, Oct 10, 2015 at 05:17:54PM +0100, Russell King - ARM Linux wrote: > > > > I _also_ notice that despite having the ARM assembly crypto functions > > enabled and built-in to the kernel, they don't appear in /proc/crypto - > > and this is because of patch 1 in this series, which blocks out any > > crypto driver which has a zero statesize (as the ARM crypto functions > > appear to have.) I found this by rebuilding the ARM crypto stuff as > > modules, and then trying to insert them: > > They're buggy and unfortunately this wasn't caught during the > review process. The import/export functions are required and > certainly not optional. OK it looks like I was confused. Yes the import and export functions are required but for shash algorithms we provide a simple default. This means that implementations can simply leave it NULL and they will then use the default import/export functions which exports the shash_desc as the state. So Russell what I'll do is apply your patch without the hunk for shash_prepare_alg. IOW we will block any ahash algorithms that leave state as zero since ahash does not provide a default import/export function (it can't because it may involve hardware state). shash algorithms on the other hand won't be affected. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
