On Sat, Oct 10, 2015 at 05:17:54PM +0100, Russell King - ARM Linux wrote: > > I _also_ notice that despite having the ARM assembly crypto functions > enabled and built-in to the kernel, they don't appear in /proc/crypto - > and this is because of patch 1 in this series, which blocks out any > crypto driver which has a zero statesize (as the ARM crypto functions > appear to have.) I found this by rebuilding the ARM crypto stuff as > modules, and then trying to insert them: They're buggy and unfortunately this wasn't caught during the review process. The import/export functions are required and certainly not optional. > # modprobe sha512-arm > modprobe: ERROR: could not insert 'sha512_arm': Invalid argument This is the correct response and what will happen is that the software implementation of sha512 will be used rather than the accelerated sha512_arm. Once the sha512_arm driver has been fixed then it can be loaded again. > So, I think it's best if this patch series is *NOT* merged until someone > who knows the kernel crypto code gets to grips with what's supposed to be > done in various parts of the code. Yes, I know that Herbert suggested > the approach in patch 1, but that _will_ cause regressions like the above > when if it's merged. Considering that the current driver can be used to trigger a kernel oops from user-space I think preventing the buggy driver from loading is the right thing to do. We can then fix them one-by-one. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
