2015-08-10 15:32 GMT+08:00 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>: > On Mon, Aug 10, 2015 at 03:18:36PM +0800, Axel Lin wrote: >> IS_ENABLED should only be used for CONFIG_* symbols. >> So use #ifdef DEBUG instead. >> >> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx> > > Nack. While the abuse is certainly wrong you're removing compiler > coverage over code which is worse. > > PLease find a way to remove the IS_ENABLED abuse without causing > the code in question to lose compiler coverage. I don't get it. sahara_decode_status/sahara_dump_descriptors/sahara_dump_links functions are mainly debug code. In original code, if IS_ENABLED(DEBUG) is false, these functions return immediately. DEBUG is defined or not is compile time determinated, so I don't understand that "removing compiler coverage over code which is worse". -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
