Re: [PATCH] crypto: sahara - Fix misuse of IS_ENABLED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 10, 2015 at 03:18:36PM +0800, Axel Lin wrote:
> IS_ENABLED should only be used for CONFIG_* symbols.
> So use #ifdef DEBUG instead.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>

Nack.  While the abuse is certainly wrong you're removing compiler
coverage over code which is worse.

PLease find a way to remove the IS_ENABLED abuse without causing
the code in question to lose compiler coverage.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux