On Mon, Jun 15, 2015 at 07:46:28PM -0700, Tadeusz Struk wrote: > > Ok I wanted to handle everything in the parse_key helper without any help from the implementation. > I can change the helper to return the key and implementation will store it in the ctx. Is this > what you are suggesting? If you want to keep the helper generic what you can do is have it take struct rsa_key instead of struct crypto_ablkcipher. It definitely should just be an optional helper as opposed to a required part of crypto_akcipher since you could have a piece of hardware that takes the encoded key directly in which case you wouldn't need the helper at all. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html