On 06/15/2015 04:59 PM, Herbert Xu wrote: >> > +struct crypto_akcipher { >> > + void *key; > Having a void * pointer here is useless. The normal way of doing > it is to place the key into the tfm context. I thought that the ctx needs to be available for implementations to store private data. This way we can allocate and store any type of key in the <alg>_parse_key() helper and still have the cxt available for implementations to use for their stuff (e.g. HW context). -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html