On Tue, 26 May 2015 11:10:41 +0200 Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> wrote: > Dear Boris Brezillon, > > On Tue, 26 May 2015 11:03:45 +0200, Boris Brezillon wrote: > > > > There is no clocks property. After a quick look on the datasheet, indeed I didn't > > > find any clock which match the CESA. In this case you should update the binding > > > documentation by adding that the clock is optional for armada-370-crypto. > > > > Hm, actually the clock is defined in Marvell's LSP, but not described > > in the datasheet. Which one should I trust :-) ? > > I'd say: trust the reality. Declare the clock in the clock driver, but > don't take a reference to it from your crypto driver. The kernel will > disable it at the end of the boot. Check if crypto still works or not, > and you'll get your answer :-) Okay, you got me: I was to lazy to test that :-). Anyway, I just did it, and apparently this clock is mandatory (the platform hangs when launching crypto requests if the clock is not referenced by the crypto device). I'll send a patch adding this clock to the armada-370 clock driver and I'll fix the dtsi accordingly. Thanks, Boris > > Thomas -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
