Re: [PATCH v3 0/2] crypto: add a new driver for Marvell's CESA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+ Jason Gunthorpe, he may be interested in this.

On Fri, May 22, 2015 at 03:33:46PM +0200, Boris Brezillon wrote:
> Hello,
> 
> This patch series adds a new driver supporting Marvell's CESA IP.
> This driver addresses some limitations of the existing one.
> From a performance and CPU load point of view the most important
> limitation in the existing driver is the lack of DMA support, thus
> preventing us from chaining crypto operations.
> 
> I know we usually try to adapt existing drivers instead of replacing them
> by new ones, but after trying to refactor the mv_cesa driver I realized it
> would take longer than writing an new one from scratch.
> 
> Here are the main features brought by this new driver:
> - support for armada SoCs (up to 38x) while keeping support for older ones
>   (Orion and Kirkwood). Note that old DT bindings (those used on Orion and
>   Kirkwood platforms) are supported, or IOTW, old DTs are compatible with
>   this new driver.
> - DMA mode to offload the CPU in case of intensive crypto usage
> - new algorithms: SHA256, DES and 3DES
> 
> In addition to this driver comes a bunch of DT updates adding crypto device
> nodes to several Marvell SoCs (those are only the tested ones, others might
> be added later).
> 
> I'd like to thank Arnaud, who has carefully reviewed several iterations of
> this driver, helped me improved my implementation, provided support for
> several crypto algorithms, provided support for armada-370 and tested
> the driver on different platforms, hence the SoB and dual MODULE_AUTHOR
> in the driver code.
> 
> Best Regards,
> 
> Boris
> 
> Changes since v2:
> - fixes in the cipher code (->dst_nents was assigned the ->src_nents
>   value and CBC state was overwritten by the IV after each chunk
>   operation)
> - spit the code as suggested by Sebastian
> 
> Changes since v1:
> - (suggested by Jason) kept the existing CESA driver and added a mechanism
>   to prevent the new driver from probing devices handled my the existing
>   one (Orion and Kirkwood platforms)
> - (reported by Paul) addressed a few Kconfig and module definition issues
> - (suggested by Andrew) added DT changes to the series
> 
> Arnaud Ebalard (6):
>   crypto: marvell/CESA: add Triple-DES support
>   crypto: marvell/CESA: add MD5 support
>   crypto: marvell/CESA: add SHA256 support
>   crypto: marvell/CESA: add support for Kirkwood SoCs
>   ARM: marvell/dt: add crypto node to armada 370 dtsi
>   ARM: marvell/dt: add crypto node to kirkwood dtsi
> 
> Boris Brezillon (10):
>   crypto: mv_cesa: request registers memory region
>   crypto: add a new driver for Marvell's CESA
>   crypto: marvell/CESA: add TDMA support
>   crypto: marvell/CESA: add DES support
>   crypto: marvell/CESA: add support for all armada SoCs
>   crypto: marvell/CESA: add allhwsupport module parameter
>   crypto: marvell/CESA: add support for Orion SoCs
>   crypto: marvell/CESA: update DT bindings documentation
>   ARM: marvell/dt: add crypto node to armada-xp.dtsi
>   ARM: marvell/dt: enable crypto on armada-xp-gp
> 
>  .../devicetree/bindings/crypto/marvell-cesa.txt    |   46 +
>  arch/arm/boot/dts/armada-370.dtsi                  |   20 +
>  arch/arm/boot/dts/armada-xp-gp.dts                 |    4 +-
>  arch/arm/boot/dts/armada-xp.dtsi                   |   31 +
>  arch/arm/boot/dts/kirkwood.dtsi                    |    2 +-
>  drivers/crypto/Kconfig                             |   18 +
>  drivers/crypto/Makefile                            |    1 +
>  drivers/crypto/marvell/Makefile                    |    2 +
>  drivers/crypto/marvell/cesa.c                      |  543 ++++++++
>  drivers/crypto/marvell/cesa.h                      |  804 ++++++++++++
>  drivers/crypto/marvell/cipher.c                    |  769 +++++++++++
>  drivers/crypto/marvell/hash.c                      | 1349 ++++++++++++++++++++
>  drivers/crypto/marvell/tdma.c                      |  224 ++++
>  drivers/crypto/mv_cesa.c                           |   13 +-
>  14 files changed, 3816 insertions(+), 10 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/crypto/marvell-cesa.txt
>  create mode 100644 drivers/crypto/marvell/Makefile
>  create mode 100644 drivers/crypto/marvell/cesa.c
>  create mode 100644 drivers/crypto/marvell/cesa.h
>  create mode 100644 drivers/crypto/marvell/cipher.c
>  create mode 100644 drivers/crypto/marvell/hash.c
>  create mode 100644 drivers/crypto/marvell/tdma.c
> 
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux