Hi! On Tue, Oct 07, 2014 at 10:02:01AM +0800, Herbert Xu wrote: > On Mon, Oct 06, 2014 at 04:43:45PM +0200, Steffen Trumtrar wrote: > > Add support for the MDHA unit in the SAHARA core. > > The MDHA can generate hash digests for MD5 and SHA1 in version 3 and > > additionally SHA224 and SHA256 in version 4. > > > > Add the SHA1 and SHA256 algorithms to the driver. > > > > The implementation was tested with the in-kernel testmgr on i.MX27 and > > i.MX53. > > > > Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx> > > --- > > Changes since v1: > > - save context in the sahara_ctx struct > > This is still wrong since the context needs to be stored in the > request. Otherwise multiple requests will corrupt each other's > state. > :-( Okay. What would I have to do to test if it works correctly? I tested this with AF_ALG from userspace and opened two file descriptors and wrote to them in turns. Wouldn't that produce multiple requests? > Also please implement export/import. > I will have to look into that. Thank you for you review. Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
