Re: [PATCH v2 2/2] crypto: sahara - add support for SHA1/256

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 06, 2014 at 04:43:45PM +0200, Steffen Trumtrar wrote:
> Add support for the MDHA unit in the SAHARA core.
> The MDHA can generate hash digests for MD5 and SHA1 in version 3 and
> additionally SHA224 and SHA256 in version 4.
> 
> Add the SHA1 and SHA256 algorithms to the driver.
> 
> The implementation was tested with the in-kernel testmgr on i.MX27 and
> i.MX53.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
> ---
> Changes since v1:
> 	- save context in the sahara_ctx struct

This is still wrong since the context needs to be stored in the
request.  Otherwise multiple requests will corrupt each other's
state.

Also please implement export/import.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux