On Tue, May 06, 2014 at 03:11:14PM -0500, Kim Phillips wrote: > > > > > I think that the form I submitted is equally easy to read. > > > > > > adding one line instead of two -> less lines overall -> more code on one > > > screen -> easier to read. > > > > I think that this is a matter of personal coding choice. > > Both the approaches are fine and compliant to kernel coding guidelines. > > I disagree, for the reasons already mentioned above. I like Kim's version better. Kim, could you respin a patch in the way you described? Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html