Thanks for the review! On 04/28/2014 11:18 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: >> >> + } else if (IS_DES(flags)) { >> + u32 tmp[DES_EXPKEY_WORDS]; >> + >> + if (keylen != QCE_DES_KEY_SIZE) >> + goto badkey; > > No need to check here since you've already set min_keysize and > max_keysize correctly. > >> + } else if (IS_3DES(flags)) { >> + if (keylen != DES3_EDE_KEY_SIZE) >> + goto badkey; > > Ditto. OK, I will delete those needless keylen checks. -- regards, Stan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html