Thanks for the review! On 04/28/2014 11:00 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: >> >> + if (IS_AES(flags)) { >> + switch (keylen) { >> + case AES_KEYSIZE_128: >> + case AES_KEYSIZE_256: >> + break; >> + default: >> + goto badkey; > > You need to support 192 here. If the hardware doesn't do that > you can work around it by using a software fallback. Sure, I will make a software fallback. Thanks. > > In general you need to provide everything that is supported by > the generic software implementation. -- regards, Stan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html