On Thu, 2014-01-09 at 17:03 +0800, Herbert Xu wrote:
> On Mon, Jan 06, 2014 at 03:39:06PM -0800, Tim Chen wrote:
> > On Mon, 2014-01-06 at 13:21 -0800, H. Peter Anvin wrote:
> > > On 01/06/2014 12:26 PM, Borislav Petkov wrote:
> > > > On Mon, Jan 06, 2014 at 10:10:55AM -0800, Tim Chen wrote:
> > > >> Yes, the code is in the file named aesni_intel_avx.S. So it should be
> > > >> clear that the code is meant for x86_64.
> > > >
> > > > How do you deduce aesni_intel_avx.S is meant for x86_64 only from the
> > > > name?
> > > >
> > > > Shouldn't it be called aesni_intel_avx-x86_64.S, as is the naming
> > > > convention in arch/x86/crypto/
> > > >
> > >
> > > Quite.
> > >
> > > -hpa
> > >
> > >
> >
> > Will renaming the file to aesni_intel_avx-x86_64.S make things clearer
> > now?
> >
> > Tim
> >
> > ---cut---here---
> >
> > >From 41656afcbd63ccb92357d4937a75629499f4fd4f Mon Sep 17 00:00:00 2001
> > From: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> > Date: Mon, 6 Jan 2014 07:23:52 -0800
> > Subject: [PATCH] crypto: Rename aesni-intel_avx.S to indicate it only
> > supports x86_64
> > To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, H. Peter Anvin <hpa@xxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, linux-crypto@xxxxxxxxxxxxxxx
> >
> > We rename aesni-intel_avx.S to aesni-intel_avx-x86_64.S to indicate
> > that it is only used by x86_64 architecture.
>
> Hmm, where is the signed-off-by line? Please resend. Thanks.
Oops, here it is again.
Tim
---cut---here---
>From 41656afcbd63ccb92357d4937a75629499f4fd4f Mon Sep 17 00:00:00 2001
From: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
Date: Mon, 6 Jan 2014 07:23:52 -0800
Subject: [PATCH] crypto: Rename aesni-intel_avx.S to indicate it only
supports x86_64
To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, H. Peter Anvin <hpa@xxxxxxxxx>
Cc: Borislav Petkov <bp@xxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, linux-crypto@xxxxxxxxxxxxxxx
We rename aesni-intel_avx.S to aesni-intel_avx-x86_64.S to indicate
that it is only used by x86_64 architecture.
---
arch/x86/crypto/Makefile | 2 +-
arch/x86/crypto/{aesni-intel_avx.S => aesni-intel_avx-x86_64.S} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename arch/x86/crypto/{aesni-intel_avx.S => aesni-intel_avx-x86_64.S} (100%)
Signed-off-by: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
---
diff --git a/arch/x86/crypto/Makefile b/arch/x86/crypto/Makefile
index 188b993..6ba54d6 100644
--- a/arch/x86/crypto/Makefile
+++ b/arch/x86/crypto/Makefile
@@ -76,7 +76,7 @@ ifeq ($(avx2_supported),yes)
endif
aesni-intel-y := aesni-intel_asm.o aesni-intel_glue.o fpu.o
-aesni-intel-$(CONFIG_64BIT) += aesni-intel_avx.o
+aesni-intel-$(CONFIG_64BIT) += aesni-intel_avx-x86_64.o
ghash-clmulni-intel-y := ghash-clmulni-intel_asm.o ghash-clmulni-intel_glue.o
sha1-ssse3-y := sha1_ssse3_asm.o sha1_ssse3_glue.o
crc32c-intel-y := crc32c-intel_glue.o
diff --git a/arch/x86/crypto/aesni-intel_avx.S b/arch/x86/crypto/aesni-intel_avx-x86_64.S
similarity index 100%
rename from arch/x86/crypto/aesni-intel_avx.S
rename to arch/x86/crypto/aesni-intel_avx-x86_64.S
--
1.7.11.7
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
