On Mon, Jan 06, 2014 at 03:39:06PM -0800, Tim Chen wrote: > On Mon, 2014-01-06 at 13:21 -0800, H. Peter Anvin wrote: > > On 01/06/2014 12:26 PM, Borislav Petkov wrote: > > > On Mon, Jan 06, 2014 at 10:10:55AM -0800, Tim Chen wrote: > > >> Yes, the code is in the file named aesni_intel_avx.S. So it should be > > >> clear that the code is meant for x86_64. > > > > > > How do you deduce aesni_intel_avx.S is meant for x86_64 only from the > > > name? > > > > > > Shouldn't it be called aesni_intel_avx-x86_64.S, as is the naming > > > convention in arch/x86/crypto/ > > > > > > > Quite. > > > > -hpa > > > > > > Will renaming the file to aesni_intel_avx-x86_64.S make things clearer > now? > > Tim > > ---cut---here--- > > >From 41656afcbd63ccb92357d4937a75629499f4fd4f Mon Sep 17 00:00:00 2001 > From: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx> > Date: Mon, 6 Jan 2014 07:23:52 -0800 > Subject: [PATCH] crypto: Rename aesni-intel_avx.S to indicate it only > supports x86_64 > To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, H. Peter Anvin <hpa@xxxxxxxxx> > Cc: Borislav Petkov <bp@xxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, linux-crypto@xxxxxxxxxxxxxxx > > We rename aesni-intel_avx.S to aesni-intel_avx-x86_64.S to indicate > that it is only used by x86_64 architecture. Hmm, where is the signed-off-by line? Please resend. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html