On Mon, Nov 25, 2013 at 7:36 AM, Shawn Landden <shawn@xxxxxxxxxxxxxxx> wrote: > Commit 35f9c09fe (tcp: tcp_sendpages() should call tcp_push() once) > added an internal flag MSG_SENDPAGE_NOTLAST, similar to > MSG_MORE. > > algif_hash, algif_skcipher, and udp used MSG_MORE from tcp_sendpages() > and need to see the new flag as identical to MSG_MORE. > > This fixes sendfile() on AF_ALG. > > v3: also fix udp > > Cc: Tom Herbert <therbert@xxxxxxxxxx> > Cc: Eric Dumazet <eric.dumazet@xxxxxxxxx> > Cc: David S. Miller <davem@xxxxxxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> # 3.4.x + 3.2.x > Reported-and-tested-by: Shawn Landden <shawnlandden@xxxxxxxxx> > Original-patch: Richard Weinberger <richard@xxxxxx> > Signed-off-by: Shawn Landden <shawn@xxxxxxxxxxxxxxx> >May I ask why you took over the my patch without even CC'in me nor >replying to the original >thread "[PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we >set MSG_SENDPAGE_NOTLAST"? >You are acting very rude. Not CCing you was an oversight. >The discussion at the original thread is not done. >Does skcipher_sendpage() really also need fixing? or UDP? UDP needs it or it will send out packets mid-sendfile. skcipher needs it or it will produce incorrect output like hash. >I didn't send another patch because I'm waiting for Eric's answer first. Eric forgot to update consumers internal consumers of MSG_MORE when he created this distinction in sendpage. That became clear when he first responded. Changing this where the consumers are makes sense. I just want this bug fixed, feel free to send your next version. >Thanks, >//richard -Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
