RE: [PATCH 5/5] crypto: talitos - add IPsec ESN support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 7 Aug 2012 04:47:51 +0300, Phillips Kim-R1AAHA <R1AAHA@xxxxxxxxxxxxx> wrote:
> On Thu, 2 Aug 2012 17:16:41 +0300
> Horia Geanta <horia.geanta@xxxxxxxxxxxxx> wrote:
> 
>> +			.cra_name = "authencesn(hmac(sha1),cbc(aes))",
>> +			.cra_driver_name = "authenc-hmac-sha1-cbc-aes-talitos",
> 
> the driver name should be authencesn, too, no?

Oops, typo. Thanks for spotting it.

> 
> Also: if the algorithm name is really all that changes, can it be
> done more space-efficiently with some string manipulation in the
> algorithm registration loop?:  If registering an "authenc"
> algorithm, also register an "authencesn" version.

Agree. Will come up with smth more elegant in v2.

> 
> The rest of the patchseries looks fine.

Thanks for reviewing.

> 
> Thanks,
> 
> Kim


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux