Re: [PATCH 5/5] crypto: talitos - add IPsec ESN support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2 Aug 2012 17:16:41 +0300
Horia Geanta <horia.geanta@xxxxxxxxxxxxx> wrote:

> +			.cra_name = "authencesn(hmac(sha1),cbc(aes))",
> +			.cra_driver_name = "authenc-hmac-sha1-cbc-aes-talitos",

the driver name should be authencesn, too, no?

Also: if the algorithm name is really all that changes, can it be
done more space-efficiently with some string manipulation in the
algorithm registration loop?:  If registering an "authenc"
algorithm, also register an "authencesn" version.

The rest of the patchseries looks fine.

Thanks,

Kim

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux